bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filename


From: José L . Doménech
Subject: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters
Date: Sun, 30 Oct 2016 09:33:19 +0100
User-agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (Gojō) APEL/10.8 EasyPG/1.0.0 Emacs/26.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)

On Sun, 30 Oct 2016 02:39:01 +0100,
address@hidden wrote:
> 
> [1  <text/plain; utf-8 (quoted-printable)>]
> tags 24620 fixed
> close 24620 26
> quit
> 
> 
> I don't worry about delays which are approximately 0 days long :)
> 
> 
> Okay, now the summary line is a bit too long.  I shortened the summary
> and pushed your patch to master.
>
Thank you.
> [2 patch <text/plain (7bit)>]
> From 27443df092bfb4ada559f8fc024e01f174a5bcb0 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Dom=C3=A9nech?= <address@hidden>
> Date: Sat, 29 Oct 2016 21:18:31 -0400
> Subject: [PATCH] Quote file names in dired compression commands
> 
> * lisp/dired-aux.el (dired-do-compress-to): Change the string
> used as shell command for compression by quoting the filenames
> used for input and output (Bug #24620).
> ---
>  lisp/dired-aux.el | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
> index d25352e..972b6b1 100644
> --- a/lisp/dired-aux.el
> +++ b/lisp/dired-aux.el
> @@ -1012,11 +1012,13 @@ dired-do-compress-to
>            (t
>             (when (zerop
>                    (dired-shell-command
> -                   (replace-regexp-in-string
> -                    "%o" out-file
> -                    (replace-regexp-in-string
> -                     "%i" (mapconcat #'file-name-nondirectory in-files " ")
> -                     (cdr rule)))))
> +                   (format-spec (cdr rule)
> +                                `((?\o . ,(shell-quote-argument out-file))
> +                                  (?\i . ,(mapconcat
> +                                           (lambda (file-desc)
> +                                             (shell-quote-argument 
> (file-name-nondirectory
> +                                                                    
> file-desc)))
> +                                           in-files " "))))))
>               (message "Compressed %d file(s) to %s"
>                        (length in-files)
>                        (file-name-nondirectory out-file)))))))
> -- 
> 2.9.3
> 
> [3  <text/plain (7bit)>]
> 
> 
> 
> Thanks for your contribution.
> 
> P.S. your mails seem to be getting duplicated (or even triplicated for the
> last one).

Sorry, it is all my fault.

I still has to get a configuration for the mailinglist+NNTP+gmane
(with wanderlust) where I get comfortable so i don't resend the
messages when a error occurs in the sending process.

Thanks again.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]