bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#18716: Patch for this bug


From: Reuben Thomas
Subject: bug#18716: Patch for this bug
Date: Tue, 8 Nov 2016 22:16:45 +0000

On 8 November 2016 at 20:04, Eli Zaretskii <address@hidden> wrote:
> From: Reuben Thomas <address@hidden>
> Date: Tue, 8 Nov 2016 17:51:26 +0000
>
> It makes dired-mark-unmarked-files act case-insensitively.

You meant case-sensitively, I presume.

​That's right, sorry.​ Fixed.

I don't understand what happened to the comment about *.JPG files on
case-sensitive filesystems,

I took it into account. My experience is that on a case-insensitive system (e.g. a GNU system), one finds occasional files like this, typically copied from other systems or extracted from archives. These are not a problem for dired-omit-mode. For visiting such files, treating auto-mode-alist and similar case-insensitively is no problem.
 
and how does this patch do TRT on
case-insensitive filesystems.

It doesn't, I've fixed it in the same way as the usage of auto-mode-alist, by testing the system type.
 
IOW, it sounds like the right solution cannot be so simple, because
this will most probably cause user complaints of the opposite kind.
No?​​
 
​See above. The only people I can see complaining are users of case-insensitive file systems on case-sensitive systems. The correct fix there is in any case to use the case-sensitivity of the file system, rather than using the operating system as an indicator of that. (The same applies to auto-mode-alist.)

Btw, if the problem is only with COPYING.LIB, maybe a better
heuristics would be to remove .lib from completion-ignored-extensions,
as it is no longer so widespread where Emacs users dwell?

​I don't think special cases are a good idea. There are other examples, e.g. CVS is a pattern, which will also match "cvs", which I have in e.g. wiki CVS repositories.

​I also added a couple of additional patches to tidy up obsolete documentation, comments and code from dired-x.el.​

--

Attachment: 0001-Match-files-case-sensitively-in-dired-x.patch
Description: Text Data

Attachment: 0002-Remove-pre-customize-dired-x.el-documentation.patch
Description: Text Data

Attachment: 0003-Remove-obsolete-comments-and-commented-code-from-dir.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]