[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#17544: 24.3; [PATCH] Improved diff-mode navigation/manipulation
From: |
npostavs |
Subject: |
bug#17544: 24.3; [PATCH] Improved diff-mode navigation/manipulation |
Date: |
Wed, 16 Nov 2016 23:33:23 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Dima Kogan <dima@secretsauce.net> writes:
> New patch attached.
>
[...]
> +
> + ;; I advance to the next hunk with skip-hunk-start set to t
> + ;; because I want the behavior of moving to the next logical
> + ;; hunk, not the legacy behavior where were would sometimes stay
> + ;; on the curent hunk. This is the behavior we get when
> + ;; navigating through hunks interactively, and we want it when
> + ;; applying hunks too. See http://debbugs.gnu.org/17544
> (when diff-advance-after-apply-hunk
> - (diff-hunk-next))))))
> + (diff-hunk-next nil t))))))
Can you mention somewhere about avoiding an infinite loop that you were
talking about before? (that's what I meant when I said to update this
comment, but if it actually makes more sense to mention that somewhere
else, please do so)
Is it really a "legacy" behavior (considering that we *need* the "legacy"
behavior in order to function correctly)?
Also, I believe usual comment style is to use "we" not "I", and you
didn't end the last sentence with a period.
- bug#17544: 24.3; [PATCH] Improved diff-mode navigation/manipulation, Dima Kogan, 2016/11/06
- bug#17544: 24.3; [PATCH] Improved diff-mode navigation/manipulation, npostavs, 2016/11/14
- bug#17544: 24.3; [PATCH] Improved diff-mode navigation/manipulation, Dima Kogan, 2016/11/16
- bug#17544: 24.3; [PATCH] Improved diff-mode navigation/manipulation,
npostavs <=
- bug#17544: 24.3; [PATCH] Improved diff-mode navigation/manipulation, Dima Kogan, 2016/11/17
- bug#17544: 24.3; [PATCH] Improved diff-mode navigation/manipulation, npostavs, 2016/11/19
- bug#17544: 24.3; [PATCH] Improved diff-mode navigation/manipulation, Dima Kogan, 2016/11/21
- bug#17544: 24.3; [PATCH] Improved diff-mode navigation/manipulation, npostavs, 2016/11/22
- bug#17544: 24.3; [PATCH] Improved diff-mode navigation/manipulation, Dima Kogan, 2016/11/23
- bug#17544: 24.3; [PATCH] Improved diff-mode navigation/manipulation, npostavs, 2016/11/28