[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#24861: [PATCH] Fix annoying "Parsing...done" message in c++-mode
From: |
Eli Zaretskii |
Subject: |
bug#24861: [PATCH] Fix annoying "Parsing...done" message in c++-mode |
Date: |
Fri, 18 Nov 2016 11:39:42 +0200 |
> From: Hong Xu <hong@topbug.net>
> Cc: 24861@debbugs.gnu.org
> Date: Tue, 15 Nov 2016 16:03:19 -0800
>
> Can you still consider this patch?
I'm okay with accepting this for the master branch, but the patch
needs some more work to fix the following issues:
. The first line of each doc string should be a complete sentence.
. The doc string of cpp-progress-message should mention
cpp-message-min-time-interval.
. The defcustom you are adding should have a :version tag.
. The calculation in cpp-progress-message should be fixed to
calculate the time difference between the current time and the time
of the previous progress message, and compare that with the value
of cpp-message-min-time-interval. The old code just looked at the
2nd member of the list returned by current-time, but that is no
longer TRT when you need to compare the time difference, because
that member can go back to zero. You need to use time-subtract.
. Last, but not least: please include ChangeLog-style commit log
message for the changes.
Thanks.
- bug#24861: [PATCH] Fix annoying "Parsing...done" message in c++-mode, Hong Xu, 2016/11/02
- bug#24861: [PATCH] Fix annoying "Parsing...done" message in c++-mode, Hong Xu, 2016/11/02
- bug#24861: [PATCH] Fix annoying "Parsing...done" message in c++-mode, Eli Zaretskii, 2016/11/02
- bug#24861: [PATCH] Fix annoying "Parsing...done" message in c++-mode, Hong Xu, 2016/11/02
- bug#24861: [PATCH] Fix annoying "Parsing...done" message in c++-mode, Eli Zaretskii, 2016/11/03
- bug#24861: [PATCH] Fix annoying "Parsing...done" message in c++-mode, Hong Xu, 2016/11/03
- bug#24861: [PATCH] Fix annoying "Parsing...done" message in c++-mode, Hong Xu, 2016/11/15
- bug#24861: [PATCH] Fix annoying "Parsing...done" message in c++-mode,
Eli Zaretskii <=
- bug#24861: [PATCH] Fix annoying "Parsing...done" message in c++-mode, Hong Xu, 2016/11/18
- bug#24861: [PATCH] Fix annoying "Parsing...done" message in c++-mode, Eli Zaretskii, 2016/11/19
- bug#24861: [PATCH] Fix annoying "Parsing...done" message in c++-mode, Hong Xu, 2016/11/19
- bug#24861: [PATCH] Fix annoying "Parsing...done" message in c++-mode, Eli Zaretskii, 2016/11/25
- bug#24861: [PATCH] Fix annoying "Parsing...done" message in c++-mode, Hong Xu, 2016/11/02
- bug#24861: [PATCH] Fix annoying "Parsing...done" message in c++-mode, Richard Stallman, 2016/11/03
bug#24861: [PATCH] Fix annoying "Parsing...done" message in c++-mode, Andreas Schwab, 2016/11/02