[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24985: Add missing provide statements

From: Philippe Vaucher
Subject: bug#24985: Add missing provide statements
Date: Tue, 22 Nov 2016 14:58:19 +0100

>  (defalias 'toggle-auto-composition 'auto-composition-mode)
> +(provide 'auto-composition-mode)

Why that? I would expect (provide 'composite) here.

I thought that the most interesting thing in composite was auto-composition-mode... same reasoning for replace.el which provided 'occur in my first patch.

Anyway, you're right, it's not very consistent. Here attached is a new patch that simply follows the file name.

In the future, I think we should consider renaming/splitting these files so each mode provide its feature (e.g occur provides 'occur, etc).

Best regards,

Attachment: 0001-Add-missing-provide-statements.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]