bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#19547: Patch for this bug


From: Thierry Volpiatto
Subject: bug#19547: Patch for this bug
Date: Sun, 27 Nov 2016 15:53:58 +0100
User-agent: mu4e 0.9.17; emacs 24.5.1

address@hidden writes:

> Thierry Volpiatto <address@hidden> writes:
>>  
>> +  Lisp_Object ignore_event;
>> +
>> +  switch (event->kind)
>> +    {
>> +    case FOCUS_IN_EVENT: ignore_event = Qfocus_in;
>> +    case FOCUS_OUT_EVENT: ignore_event = Qfocus_out;
>> +    case HELP_EVENT: ignore_event = Qhelp;
>> +    case ICONIFY_EVENT: ignore_event = Qiconify;
>> +    case DEICONIFY_EVENT: ignore_event = Qdeiconify;
>> +    case SELECTION_REQUEST_EVENT: ignore_event = Qselection_request;
>
> You need a break at the end of each case, otherwise all events would be
> treated as SELECTION_REQUEST_EVENT.
>
>     case FOCUS_IN_EVENT: ignore_event = Qfocus_in; break;

You answer exactly at what I was wondering about, is break needed or not?


>> +  Vwhile_no_input_ignore_events = Qnil;
>> +    /* = listn (Qfocus_in, Qfocus_out, Qhelp, Qiconify, Qdeiconify, 
>> Qselection_request); */
>
> I think something like this should work:
>
>     listn (CONSTYPE_PURE, 6, Qfocus_in, Qfocus_out, Qhelp, Qiconify, 
> Qdeiconify, Qselection_request);

Same here, I had to use Qnil because I always had errors when trying to
feed this variable here, I will try tonight if that works.
I wondered also if instead the variable could be feeded from lisp as
suggested by Eli, but I don't know yet where is the good place for this
and how.

Many thanks for your help.

-- 
Thierry





reply via email to

[Prev in Thread] Current Thread [Next in Thread]