[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24966: 26.0.50; test-completion with alist COLLECTION calls PREDICAT

From: npostavs
Subject: bug#24966: 26.0.50; test-completion with alist COLLECTION calls PREDICATE incorrectly
Date: Mon, 28 Nov 2016 22:31:32 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Noam Postavsky <address@hidden> writes:

> On Mon, Nov 28, 2016 at 3:59 PM, Mark Oteiza <address@hidden> wrote:
>>> address@hidden writes:
>>> >
>>> > I tentatively suggest the patch below, but I want to add some tests
>>> > before commiting anything.
>>> While adding tests, I found another inconsistency: when given a
>>> hashtable with symbol keys, test-completion passes the symbol-name to
>>> PREDICATE, while all-completions and try-completion pass the original
>>> symbol key.  Here are two patches, the first for this bug, and the
>>> second for the other inconsistency.
>> The first hunk of 2/2 isn't applying here.
> Oh, that's probably because I generated it with -w, so some whitespace
> changes are missing in 1/2. I'll post a full patch tonight.

Here are the same patches with full whitespace changes.

Attachment: v1-0001-Give-test-completion-s-PREDICATE-full-alist-entry.patch
Description: patch

Attachment: v1-0002-Give-test-completion-s-PREDICATE-the-hashtable-ke.patch
Description: patch

reply via email to

[Prev in Thread] Current Thread [Next in Thread]