[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#25049: ibuffer bug when saving existing filter, with patches
From: |
Tino Calancha |
Subject: |
bug#25049: ibuffer bug when saving existing filter, with patches |
Date: |
Wed, 30 Nov 2016 16:02:53 +0900 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) |
Christopher Genovese <genovese@cmu.edu> writes:
> I've attached a modified patch file that includes
> all your suggested changes. I did some squashing
> and editing, so this patch has the same three parts
> as before, with properly formatted Change Logs in
> each.
Thank you very much fr your prompt replay!
I)
+ 'follow-link t
+ 'help-echo "Click or RET: save new value in customize"
+ 'action (lambda (b)
+ (if (not (fboundp 'customize-save-variable))
+ (message "Customize not available; value not saved")
+ (customize-save-variable 'ibuffer-saved-filters
+ ibuffer-saved-filters)
+ (message "Saved updated ibuffer-saved-filters."))))
The lambda form above doesn't use its 'b' argument, so i have dropped it.
II)
I see you define `ibuffer-update-saved-filters-format' right before
than `ibuffer-saved-filters', because this defcustom use that function
to set its default.
In the other hand `ibuffer-repair-saved-filters' isn't used by any
defcustom so i moved out after the variable definitions.
If we don't get further comments to address in 1 week, then let's
push this fix to the master branch.
Thank you
Tino
- bug#25049: ibuffer bug when saving existing filter, with patches, Christopher Genovese, 2016/11/28
- bug#25049: ibuffer bug when saving existing filter, with patches, Tino Calancha, 2016/11/29
- bug#25049: ibuffer bug when saving existing filter, with patches, Christopher Genovese, 2016/11/29
- bug#25049: ibuffer bug when saving existing filter, with patches, Tino Calancha, 2016/11/29
- bug#25049: ibuffer bug when saving existing filter, with patches, Christopher Genovese, 2016/11/30
- bug#25049: ibuffer bug when saving existing filter, with patches,
Tino Calancha <=
- bug#25049: ibuffer bug when saving existing filter, with patches, npostavs, 2016/11/30
- bug#25049: ibuffer bug when saving existing filter, with patches, Tino Calancha, 2016/11/30
- bug#25049: ibuffer bug when saving existing filter, with patches, Tino Calancha, 2016/11/30
- bug#25049: ibuffer bug when saving existing filter, with patches, Christopher Genovese, 2016/11/30
- bug#25049: ibuffer bug when saving existing filter, with patches, Tino Calancha, 2016/11/30