[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#25025: python-shell-calculate-command is wrong
From: |
Eli Zaretskii |
Subject: |
bug#25025: python-shell-calculate-command is wrong |
Date: |
Fri, 02 Dec 2016 16:51:15 +0200 |
> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Fri, 2 Dec 2016 09:16:04 -0500
> Cc: 25025@debbugs.gnu.org, Clément Pit--Claudel <clement.pit@gmail.com>
>
> On Fri, Dec 2, 2016 at 2:35 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> >> --- a/lisp/progmodes/python.el
> >> +++ b/lisp/progmodes/python.el
> >> @@ -2379,7 +2379,7 @@ python-shell-internal-get-process-name
> >> (defun python-shell-calculate-command ()
> >> "Calculate the string used to execute the inferior Python process."
> >> (format "%s %s"
> >> - (shell-quote-argument python-shell-interpreter)
> >> + (combine-and-quote-strings (list python-shell-interpreter))
> >> python-shell-interpreter-args))
> >
> > Isn't combine-and-quote-strings wrong for quoting shell commands?
> > AFAIR, it doesn't DTRT with some special characters that can appear in
> > file names on Unix. Am I mistaken?
>
> It's not a shell command though, hence this bug.
No, but the code in question generates a shell command, from the file
name of the interpreter and its arguments. Right?
- bug#25025: python-shell-calculate-command is wrong, Eli Zaretskii, 2016/12/01
- bug#25025: python-shell-calculate-command is wrong, Clément Pit--Claudel, 2016/12/02
- bug#25025: python-shell-calculate-command is wrong, Noam Postavsky, 2016/12/02
- bug#25025: python-shell-calculate-command is wrong, Clément Pit--Claudel, 2016/12/02
- bug#25025: python-shell-calculate-command is wrong, npostavs, 2016/12/09