[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#20896: patch to add chained indentation

From: Dmitry Gutov
Subject: bug#20896: patch to add chained indentation
Date: Fri, 13 Jan 2017 04:09:18 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0

On 12.01.2017 07:01, Tom Tromey wrote:

I'll redo the test this way.


Dmitry> As for review: js--skip-term-backward seems to be doing something
Dmitry> similar to the loop in js--multi-line-declaration-indentation.
Dmitry> Maybe a extraction and unification is in order.

I don't really see it.  Could you explain more?

The `while' loop jumps to the beginning of the current "assignment expression".

`js--skip-terms-backward' is similar because it skips to the beginning of the call chain. It's more narrow, though (the other function also jumps over binary operators).

Anyway, I'm not so sure there's much value in unifying the implementations anymore.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]