[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#25440: 25.1.90; Incorrect documentation for sql-product-alist in sql
From: |
Eli Zaretskii |
Subject: |
bug#25440: 25.1.90; Incorrect documentation for sql-product-alist in sql.el |
Date: |
Sat, 14 Jan 2017 10:41:43 +0200 |
> From: Alex Hutcheson <alexhutcheson@google.com>
> Date: Fri, 13 Jan 2017 12:01:59 -0500
>
> The documentation for the variable 'sql-product-alist' incorrectly
> describes the appropriate value for the :sqli-comint-func feature.
> The documentation specifies:
> > :sqli-comint-func name of a function which accepts no
> > parameters that will use the values of ...
>
> However, the function actually needs to have two parameters: 'product'
> and 'options'. See the following two examples in sql.el to confirm:
> http://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/progmodes/sql.el#n159
> http://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/progmodes/sql.el#n4337
>
> The doc string for :sqli-comint-func (here:
> http://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/progmodes/sql.el#n554)
> needs to be changed to reflect this.
Thanks, fixed for Emacs 25.2.