From c5669776b1abec979249ff9218ba8251500fc704 Mon Sep 17 00:00:00 2001 From: Nikolay Kudryavtsev Date: Tue, 3 Jan 2017 01:21:19 +0300 Subject: [PATCH] Prevent package-install from asking to save buffers * lisp/emacs-lisp/bytecomp.el (byte-recompile-directory): New argument `ignore-modified-buffers' that prevents `save-some-buffers' from getting called. * doc/lispref/compile.texi: Documented `ignore-modified-buffers' argument of `byte-recompile-directory'. * lisp/emacs-lisp/package.el (package--compile): Use `ignore-modified-buffers' when calling `byte-recompile-directory'. --- doc/lispref/compile.texi | 6 +++++- lisp/emacs-lisp/bytecomp.el | 10 +++++++--- lisp/emacs-lisp/package.el | 2 +- 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/doc/lispref/compile.texi b/doc/lispref/compile.texi index b1cc04b..239d7ee 100644 --- a/doc/lispref/compile.texi +++ b/doc/lispref/compile.texi @@ -198,7 +198,7 @@ Compilation Functions @end example @end deffn -@deffn Command byte-recompile-directory directory &optional flag force +@deffn Command byte-recompile-directory directory &optional flag force ignore-modified-buffers @cindex library compilation This command recompiles every @samp{.el} file in @var{directory} (or its subdirectories) that needs recompilation. A file needs @@ -217,6 +217,10 @@ Compilation Functions If @var{force} is non-@code{nil}, this command recompiles every @samp{.el} file that has a @samp{.elc} file. +If @var{ignore-modified-buffers} is non-@code{nil}, this command avoids +saving modified buffers before compilation. Otherwise +@code{save-some-buffers} is called. + The returned value is unpredictable. @end deffn diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index 63be7e2..fda25ae 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -1621,7 +1621,7 @@ byte-force-recompile (byte-recompile-directory directory nil t)) ;;;###autoload -(defun byte-recompile-directory (directory &optional arg force) +(defun byte-recompile-directory (directory &optional arg force ignore-modified-buffers) "Recompile every `.el' file in DIRECTORY that needs recompilation. This happens when a `.elc' file exists but is older than the `.el' file. Files in subdirectories of DIRECTORY are processed also. @@ -1634,12 +1634,16 @@ byte-recompile-directory before scanning it. If the third argument FORCE is non-nil, recompile every `.el' file -that already has a `.elc' file." +that already has a `.elc' file. + +If forth argument IGNORE-MODIFIED-BUFFERS is non-nil, do not try to save +modified buffers before compilation." (interactive "DByte recompile directory: \nP") (if arg (setq arg (prefix-numeric-value arg))) (if noninteractive nil - (save-some-buffers) + (when (not ignore-modified-buffers) + (save-some-buffers)) (force-mode-line-update)) (with-current-buffer (get-buffer-create byte-compile-log-buffer) (setq default-directory (expand-file-name directory)) diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 6728f1b..0851c5e 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -946,7 +946,7 @@ package--compile (let ((warning-minimum-level :error) (save-silently inhibit-message) (load-path load-path)) - (byte-recompile-directory (package-desc-dir pkg-desc) 0 t))) + (byte-recompile-directory (package-desc-dir pkg-desc) 0 t t))) ;;;; Inferring package from current buffer (defun package-read-from-string (str) -- 2.10.2.windows.1