bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25618: 25.1.91; More precise limit for tagging expensive tests


From: Tino Calancha
Subject: bug#25618: 25.1.91; More precise limit for tagging expensive tests
Date: Sat, 4 Feb 2017 23:13:16 +0900 (JST)
User-agent: Alpine 2.20 (DEB 67 2015-01-07)



On Sat, 4 Feb 2017, Noam Postavsky wrote:

On Sat, Feb 4, 2017 at 8:42 AM, Tino Calancha <address@hidden> wrote:

Prefer set a numeric limit of seconds than using the word 'few'.

For instance, in my box the test `cl-seq-test-bug24264' in
test/lisp/emacs-lisp/cl-seq-tests.el
takes 7 s.
With an explicit numeric threshold is easier to decide whether this test
must be tagged as expensive or not.

In following patch i define a few as 2-3 seconds.  Other people might
prefer 4-5 or even higher.
Please, suggest a proper value to consider a test as expensive.

Is it worth specifying this so precisely? The time elapsed depends on
the speed of the computer you run it on (also, whether Emacs is
compiled with optimization or not). A test that takes 2 seconds on
your computer might easily take 5 seconds on mine.
When i run the test suite, the test mentioned before takes significantly
longer than the others. I feel like it could be considered as slightly expensive. After reading 'some few seconds' in CONTRIBUTE i am still in doubt on that. It could be more clear.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]