bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25618: 25.1.91; More precise limit for tagging expensive tests


From: Eli Zaretskii
Subject: bug#25618: 25.1.91; More precise limit for tagging expensive tests
Date: Fri, 10 Feb 2017 10:49:38 +0200

> From: Tino Calancha <address@hidden>
> Date: Sun, 5 Feb 2017 02:54:03 +0900 (JST)
> cc: Tino Calancha <address@hidden>, address@hidden
> 
> On Sat, 4 Feb 2017, Eli Zaretskii wrote:
> 
> >> From: Tino Calancha <address@hidden>
> >> Date: Sat, 04 Feb 2017 22:42:44 +0900
> >>
> >>
> >> Prefer set a numeric limit of seconds than using the word 'few'.
> >>
> >> For instance, in my box the test `cl-seq-test-bug24264' in
> >> test/lisp/emacs-lisp/cl-seq-tests.el
> >> takes 7 s.
> >> With an explicit numeric threshold is easier to decide whether this test
> >> must be tagged as expensive or not.
> >>
> >> In following patch i define a few as 2-3 seconds.  Other people might
> >> prefer 4-5 or even higher.
> >> Please, suggest a proper value to consider a test as expensive.
> >
> > I think 2-3 sec is negligible, and 7 sec is not long enough to annoy.
> > 10 sec or more is beginning to sound like it comes close to "too
> > long", and 20 sec is definitely too long.
> Thank you.  Now is clear.
> Are you OK with keep the sentence as it is now?
> I mean, keep: 'some few seconds'.

It's okay to leave it as is.  I also don't object to saying something
more specific, but 2-3 sec sound just too few to me.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]