bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25714: 25.1.91; make "update" flag work with vc-retrieve-tag in git


From: Tom Tromey
Subject: bug#25714: 25.1.91; make "update" flag work with vc-retrieve-tag in git and hg
Date: Mon, 13 Feb 2017 18:32:38 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux)

>>>>> "Dmitry" == Dmitry Gutov <address@hidden> writes:

Dmitry> Any idea why the (vc-resynch-buffer dir t t t) call at the end of
Dmitry> vc-retrieve-tag doesn't do the job?

I must have tested incorrectly, because when I revert my patch, it still
seems to work now :(
Sorry about that.  Maybe you should try it to be sure.

How about this patch, that just removes the comments?

Tom

commit 7f2bcbf75eca6e00a8a428d6c838945e01556c1b
Author: Tom Tromey <address@hidden>
Date:   Mon Feb 13 17:24:04 2017 -0700

    Make vc-git and vc-hg revert buffers on branch switch
    
    * lisp/vc/vc-git.el (vc-git-retrieve-tag): Remove comment.
    * lisp/vc/vc-hg.el (vc-hg-retrieve-tag): Remove comment.

diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
index 0f58892..8a22d74 100644
--- a/lisp/vc/vc-git.el
+++ b/lisp/vc/vc-git.el
@@ -1240,9 +1240,7 @@ vc-git-create-tag
 
 (defun vc-git-retrieve-tag (dir name _update)
   (let ((default-directory dir))
-    (vc-git-command nil 0 nil "checkout" name)
-    ;; FIXME: update buffers if `update' is true
-    ))
+    (vc-git-command nil 0 nil "checkout" name)))
 
 
 ;;; MISCELLANEOUS
diff --git a/lisp/vc/vc-hg.el b/lisp/vc/vc-hg.el
index 2f9487c..8a2b077 100644
--- a/lisp/vc/vc-hg.el
+++ b/lisp/vc/vc-hg.el
@@ -76,7 +76,7 @@
 ;; - annotate-extract-revision-at-line ()      OK
 ;; TAG SYSTEM
 ;; - create-tag (dir name branchp)             OK
-;; - retrieve-tag (dir name update)            OK FIXME UPDATE BUFFERS
+;; - retrieve-tag (dir name update)            OK
 ;; MISCELLANEOUS
 ;; - make-version-backups-p (file)             ??
 ;; - previous-revision (file rev)              OK
@@ -562,7 +562,6 @@ vc-hg-retrieve-tag
   "Retrieve the version tagged by NAME of all registered files at or below 
DIR."
   (let ((default-directory dir))
     (vc-hg-command nil 0 nil "update" name)
-    ;; FIXME: update buffers if `update' is true
     ;; TODO: update *vc-change-log* buffer so can see @ if --graph
     ))
 





reply via email to

[Prev in Thread] Current Thread [Next in Thread]