[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#21072: Brave new mark-defun (and a testing tool)
From: |
Marcin Borkowski |
Subject: |
bug#21072: Brave new mark-defun (and a testing tool) |
Date: |
Thu, 16 Feb 2017 05:40:33 +0100 |
User-agent: |
mu4e 0.9.19; emacs 26.0.50.5 |
On 2017-02-15, at 20:27, Stefan Monnier <monnier@IRO.UMontreal.CA> wrote:
>>> Regardless of the answer you give above, I'm wondering in which kind of
>>> circumstance we'd want to test if we're on "a line containing only
>>> a comment".
>> You will be surprised, then, that I actually did use a very similar
>> function in completely another circumstance: a command that counts
>> source lines of code in a region, and excludes lines containing only
>> whitespace, comments and docstrings. (Never mind the discussion about
>> whether SLOC is meaningful in any sense;-).)
>
> My point is that it's not very frequent to need this exact definition of
> a "comment line" and that there are various other possible definitions
> one might need in other circumstances.
> So at the very least, the doc should clarify which definition of
> "comment line" it uses.
Understood. Do you have then any better idea for the name of this
function? beginning-of-defun--incomment-line-p seems to specific,
in-comment-line-p _may_ be indeed too general. (I'll make the docstring
more precise, of course.)
Thank you all for looking at the patch,
--
Marcin Borkowski
- bug#21072: Brave new mark-defun (and a testing tool), Marcin Borkowski, 2017/02/14
- bug#21072: Brave new mark-defun (and a testing tool), Dmitry Gutov, 2017/02/14
- bug#21072: Brave new mark-defun (and a testing tool), Marcin Borkowski, 2017/02/14
- Message not available
- bug#21072: Brave new mark-defun (and a testing tool), Marcin Borkowski, 2017/02/15
- bug#21072: Brave new mark-defun (and a testing tool), Stefan Monnier, 2017/02/15
- bug#21072: Brave new mark-defun (and a testing tool), Marcin Borkowski, 2017/02/15
- bug#21072: Brave new mark-defun (and a testing tool), Stefan Monnier, 2017/02/15
- bug#21072: Brave new mark-defun (and a testing tool),
Marcin Borkowski <=
- bug#21072: Brave new mark-defun (and a testing tool), Stefan Monnier, 2017/02/16
- bug#21072: Brave new mark-defun (and a testing tool), Marcin Borkowski, 2017/02/17