bug#25901: 25.2; fit-frame-to-buffer not functional in OS X

[Charles A. Roelli]

On Wed, Mar 01 2017 at 09:28:40 am, martin rudalics wrote:

>> - emacs -Q
>> - (M-x toggle-debug-on-error)
>> - M-x fit-frame-to-buffer
>>
>> Debugger entered--Lisp error: (wrong-type-argument terminal-live-p "gray")
>>    ns-display-monitor-attributes-list("gray")
>>    display-monitor-attributes-list("gray")
>>    fit-frame-to-buffer()
>>    funcall-interactively(fit-frame-to-buffer)
>>
>> "gray" is the hostname of the machine.
>>
>>   GNU Emacs 25.2.1 (x86_64-apple-darwin10.8.0, NS appkit-1038.36 Version 
>> 10.6.8 (Build 10K549))
>>   of 2017-02-22 built on gray
>> Windowing system distributor 'Apple', version 10.3.1038
>> Configured using:
>>   'configure --with-modules'
>>
>> Configured features:
>> JPEG RSVG NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES
>
> Too bad.  Does it work when you replace
>
>            (monitor-attributes (car (display-monitor-attributes-list
>                                      (frame-parameter frame 'display))))
>
> by
>
>            (monitor-attributes (car (display-monitor-attributes-list frame)))
>
> in ‘fit-frame-to-buffer’?
>
> martin

That does work.  I don't understand exactly how the display naming
things work on OS X (no time to look into it ATM), but if the docstring
of display-monitor-attributes-list is correct:

  Return a list of physical monitor attributes on DISPLAY.
  DISPLAY can be a display name, a terminal name, or a frame.

then the DISPLAY argument should work with the return value of
(frame-parameter frame 'display).