[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25895: Remove update-game-score

From: Ulrich Mueller
Subject: bug#25895: Remove update-game-score
Date: Fri, 10 Mar 2017 07:42:50 +0100

>>>>> On Thu, 9 Mar 2017, Paul Eggert wrote:

> Thanks, good suggestion. Proposed patch attached. I'll CC: this to
> Ulrich Müller to see whether he has thoughts on this that are
> relevant to Gentoo, since he sent in a Gentoo-related bug report
> about setgid a couple of years ago. Ulrich, the new bug report is
> here:

> https://bugs.gnu.org/25895

I am not happy about this. Gentoo installs update-game-score as a
setgid binary and it is working well. I agree that setuid binaries are
generally frowned upon, but that is much less the case for setgid.

In fact, installing such binaries setgid and beloging to a "games" or
similar group is valid policy in both Debian and Gentoo:

   $ ls -l /usr/libexec/emacs/25.2/x86_64-pc-linux-gnu/
   total 88
   -rwxr-xr-x 1 root root     10344 Mar  2 09:35 hexl
   -rwxr-xr-x 1 root root     27104 Mar  2 09:35 movemail
   -rwxr-xr-x 1 root root      6184 Mar  2 09:35 profile
   -rwxr-xr-x 1 root root     21154 Mar  2 09:35 rcs2log
   -rwxr-s--x 1 root gamestat 14656 Mar  2 09:35 update-game-score

Also I don't buy the argument that these files were a maintenance
burden. Browsing the git history of lib-src/update-game-score.c and
lisp/play/gamegrid.el, I see that the last nontrivial change to them
was a patch that I submitted myself more than two years ago.

I think you need better reasons for removal of working functionality.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]