[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#26066: 26.0.50; vc-git-status gives wrong result

From: Jonathan Ganc
Subject: bug#26066: 26.0.50; vc-git-status gives wrong result
Date: Mon, 10 Apr 2017 00:41:15 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

I agree with the suggestions from both of you and have made the corrections. I have attached a new patch. Please let me know if you have further thoughts.

I will gladly sign a copyright assignment, if you point me to where I can do that.

On 04/09/2017 11:26 PM, Dmitry Gutov wrote:
On 31.03.2017 06:16, Jonathan Ganc wrote:
+  (save-match-data
+ (let* ((default-directory (file-name-directory (expand-file-name file)))

We don't require or expect that any particular function keeps the match data intact. I don't think that save-match-data is needed here.

Aside from this an Noam's comments, the patch is long enough to require a copyright assignment. I didn't find yours on file.

Will you sign one?

Attachment: 0001-update-vc-git.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]