[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#21072: Brave new mark-defun (and a testing tool)

From: Noam Postavsky
Subject: bug#21072: Brave new mark-defun (and a testing tool)
Date: Thu, 27 Apr 2017 17:48:06 -0400

On Thu, Apr 27, 2017 at 12:43 PM, Marcin Borkowski <address@hidden> wrote:
> On 2017-04-24, at 14:52, address@hidden wrote:
>> Actually, now that I've applied this thing properly, I notice 2 test
>> failures in batch mode:
>> 2 unexpected results:
>>    FAILED  mark-defun-arg-region-active
>>    FAILED  mark-defun-no-arg-region-active
>> They pass when run in interactive mode (I haven't looked into why).
> Strangely enough, they also fail with my original code.  Does anyone
> have any idea why that might be the case?

Oh I see what it is, your test depends on `transient-mark-mode' being
enabled. With --batch, that defaults to nil. Should we be testing in
both modes or just explicitly set it to t?

PS I noticed some problems with elisp-tests-with-temp-buffer while
looking at this, I pushed a fix to fix/bug-21072 [1: 04741f0].

1: 2017-04-27 17:38:09 -0400 04741f02cca95147581e05cb49b54e6dbf8bed56
  Fix elisp-tests-with-temp-buffer compilation

reply via email to

[Prev in Thread] Current Thread [Next in Thread]