[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#23007: 24.5; buggy interactive search with middle click
From: |
Alex |
Subject: |
bug#23007: 24.5; buggy interactive search with middle click |
Date: |
Mon, 29 May 2017 20:47:10 -0600 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
npostavs@users.sourceforge.net writes:
> Alex <agrambot@gmail.com> writes:
>
>> + (let ((overriding-terminal-local-map nil))
>> + (setq binding (key-binding (this-command-keys-vector) t)))
>
> IMO, it would be better style to do something like
>
> (let ((binding (let ((overriding-terminal-local-map nil))
> (key-binding (this-command-keys-vector) t))))
> ...)
That was my first idea, but at the time I thought it was better style to
use the setq version instead. :)
Your version makes the binding more obvious, though, so I updated the
patch to use it. I've attached it below.
PS: I don't immediately see a reason to check for the (mark) in the
condition. I tested by deactivating the mark explicitly, and setting
mark-even-if-inactive to nil in the window, but it still worked
correctly.
0001-Limit-scope-of-local-overriding-terminal-local-map.patch
Description: patch v2
bug#23007: 24.5; buggy interactive search with middle click,
Alex <=