|
From: | Dmitry Gutov |
Subject: | bug#25995: 26.0.50; Mismatch between documented and actual behaviour of icomplete |
Date: | Mon, 19 Jun 2017 03:19:16 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 |
On 3/10/17 1:25 AM, npostavs@users.sourceforge.net wrote:
This seems to have been introduced by [1: 65797b1]. I guess completion-pcm--filename-try-filter should not reverse its input? 1: 2016-04-28 19:31:43 +0200 65797b1d75e9f608ffd50fd88be47a854b143bb1 Make icomplete respect `completion-ignored-extensions' --- i/lisp/minibuffer.el +++ w/lisp/minibuffer.el @@ -3257,7 +3257,7 @@ completion-pcm--filename-try-filter "\\)\\'"))) (dolist (f all) (unless (string-match-p re f) (push f try))) - (or try all)))) + (or (nreverse try) all))))
Looks good to me, thank you.But what are the chances of this 'nreverse' (or the whole function) being performance-significant?
Maybe we could switch this code to `cl-delete-if'. From my testing, it's considerably faster than dolist+push (even without nreverse).
[Prev in Thread] | Current Thread | [Next in Thread] |