[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27427: 26.0.50; Native line numbers lead to display error in company

From: Dmitry Gutov
Subject: bug#27427: 26.0.50; Native line numbers lead to display error in company-mode popup
Date: Thu, 22 Jun 2017 01:41:15 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0

On 6/21/17 9:15 PM, Eli Zaretskii wrote:
Or do you just assume the column there is

Yep! And there are zero outstanding bug reports related to this.

What I had in mind is to come up with a solution that will work the
same with line-prefix specified in any way we support.  Then you won't
need to put the line-prefix property on the company overlay.

I'm saying it's not easy, and I'm not brimming with ideas.

Can't we put native line numbering outside of the window bounds? Like linum and nlinum do.

Btw, can you remind me why we don't use pop-up menus for company

Event handing and theming issues (at least with GUI frames).

- GUI menus have only two colors: background and foreground (and maybe "inactive"). Not sure about the terminal mode menus.

- Menus take over the event loop. IIRC you suggested a way to get around this, but that doesn't solve the previous problem anyway.

IIUC we've settled on using chromeless frames for the popup. It seems Martin is cooking something in this direction (almost ready?), but I haven't tried using them. And that would take some work.

Last I checked, Clément was interested, but no results yet.

Could be.  Can I seduce you to try the line-numbers branch? ;-)

Consider me seduced. I'm seeing the same behavior as what Alexander reported. There are two problems:

1. The first visual line containing the popup has the line number at its beginning. And as such, the popup line is shifted to the right.

2. The rest don't have the line numbers before them, so they are positioned correctly. This may or may not be considered a problem (there's probably nothing we can do about the lack of numbers), but the inconsistency between the different popup lines seems like it would require some special handling in the code.

And whatever that additional code would do, it would have to be reconciled with line-prefix as well, so as not to make things worse.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]