[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27559: 26.0.50; [PATCH] Add tests for cl-macs.el

From: Tino Calancha
Subject: bug#27559: 26.0.50; [PATCH] Add tests for cl-macs.el
Date: Tue, 04 Jul 2017 14:04:14 +0900
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

Alex <address@hidden> writes:

> That's more or less what I did at first, but I figured since cl-loop is
> a large macro, that it's best to quote the macro so that an accidental
> error doesn't halt testing.
I prefer just use (eval '...) in those cases where the expansion fails.
That way the file is more readable, and a reader focus her eye in those
failing expansions.
Maybe we could add a comment in the file saying that those
`should-error' are failing expansions to be fixed.
> For instance, some for-as-arith tests that aren't marked as should-error
> currently error in master. As an example, (cl-loop for i above 0 by 2
> downfrom 10 collect i) should work, but it errors. I have a working
> patch for these, but I wanted to make the tests first.
That's great! Looking forward to see the patch fixing these problems.
> It would be nice if the ert tests in general could just continue on with
> testing even if there are macro-expansion errors.
Sure, as long as the errors are expected.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]