|
From: | Paul Eggert |
Subject: | bug#28023: fix make-temp-file race on local host |
Date: | Sun, 13 Aug 2017 00:21:03 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
Michael Albinus wrote:
Paul Eggert<eggert@cs.ucla.edu> writes:Tramp needs to support a new method make-temp-file that creates a file (or directory) atomically, as make-temp-file does locally now.That means, make-temp-file shall be converted into a magic file name operation. I'll do my best, but I don't know whether we could get an implementation for all Tramp methods w/o a race condition.Tramp also needs to support the excl flag of write-region (currently it ignores that flag).This sounds trivial. And yes, it will help.
Thanks for doing that. Because of that, I'm no longer seeing a race in make-temp-file, even for Tramp files. That is, although my proposed patch is still a performance win on local files, I don't see how it is a correctness win any more. It's still worth installing for the performance reasons, though, so I did that and I am marking this bug as done.
I was planning to write this up as a bug report after the patch goes in.Pls do.
To some extent this is moot now, if I understand things correctly. That is, the only reason to write this up now would be for performance reasons, not a race condition.
There is still a race involving destination directories, for both Tramp and non-Tramp versions. I plan to take a look at that next.
[Prev in Thread] | Current Thread | [Next in Thread] |