[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#21714: [PATCH] Add multiframe image support to NS port (bug#21714)
From: |
Alan Third |
Subject: |
bug#21714: [PATCH] Add multiframe image support to NS port (bug#21714) |
Date: |
Sun, 13 Aug 2017 14:37:45 +0100 |
User-agent: |
Mutt/1.7.2 (2016-11-26) |
On Sun, Aug 13, 2017 at 09:21:44AM -0400, npostavs@users.sourceforge.net wrote:
> Alan Third <alan@idiocy.org> writes:
>
> > +static Lisp_Object
> > +image_spec_value (Lisp_Object spec, Lisp_Object key, bool *found)
> > +{
> > + Lisp_Object tail;
> > +
> > + eassert (valid_image_p (spec));
> > +
> > + for (tail = XCDR (spec);
> > + CONSP (tail) && CONSP (XCDR (tail));
> > + tail = XCDR (XCDR (tail)))
> > + {
> > + if (EQ (XCAR (tail), key))
> > + {
> > + if (found)
> > + *found = 1;
> > + return XCAR (XCDR (tail));
> > + }
> > + }
>
> Wouldn't it be clearer to call Fplist_get here?
Yes I think it would. I actually just copied the code from image.c, so
would it maybe be worth tidying up that code too?
Thanks!
--
Alan Third