[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#27952: 26.0.50; Combine archive-int-to-mode and tar-grind-file-mode
From: |
npostavs |
Subject: |
bug#27952: 26.0.50; Combine archive-int-to-mode and tar-grind-file-mode |
Date: |
Wed, 16 Aug 2017 08:00:03 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) |
Tino Calancha <tino.calancha@gmail.com> writes:
> + (replace-regexp-in-string
> + ",\\`" ""
This regex doesn't match anything, did you mean \\' at the end?
> (defun tar-grind-file-mode (mode)
> "Construct a `rw-r--r--' string indicating MODE.
> +MODE should be an integer which is a file mode value.
> +For instance, if mode is 448, then it produces `rwx------'."
IMO, it's clearer if you write #o700 instead of 448 here, perhaps in the
code too.