|
From: | Ken Brown |
Subject: | bug#27986: 26.0.50; 'rename-file' can rename files without confirmation |
Date: | Sat, 19 Aug 2017 18:04:49 -0400 |
User-agent: | Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 8/19/2017 5:37 PM, Paul Eggert wrote:
Ken Brown wrote:This is now done. The implementation will appear in the next Cygwin release. When that release occurs, I'll install something like the attached patch.Thanks.Question: Is the patch OK as is, or should I make the call to renameat2 conditional on CYGWIN? In other words, is it safe to assume that renameat2 is defined on any platform on which RENAME_NOREPLACE is defined but not SYS_renameat2?It should be OK, for the same reason the RENAME_EXCL branch is OK (it assumes renameatx_np). If we run across some future platform where it doesn't work, we can port it then. As far as I know, Cygwin will be the first platform with renameat2 in its C library.
Is there any (good) reason that glibc doesn't provide a wrapper for it? It seems that this would be pretty trivial to do.
Ken
[Prev in Thread] | Current Thread | [Next in Thread] |