bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#28227: 26.0.50; Tramp tests are slow


From: Michael Albinus
Subject: bug#28227: 26.0.50; Tramp tests are slow
Date: Fri, 01 Sep 2017 14:28:33 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

Gemini Lasswell <address@hidden> writes:

Hi Gemini,

> Here's a new patch which uses defun and doesn't have the let binding.
> Performance is not noticably different.

Looks good to me, thanks a lot! You could apply this to master.

`tramp-prefix-method-regexp-alist' might be renamed to
`tramp-method-regexp-alist'.

And `tramp-*-regexp-alist' might be derived from `tramp-*-format-alist',
as the docstring says. Otherwise, you would use the same string literals
twice, which is always good for errors during maintenance. Something like

(defconst tramp-prefix-regexp-alist
  (mapcar (lambda (x) (cons (car x) (concat "^" (regexp-quote (cdr x)))))
          tramp-prefix-format-alist)
  "Alist of regexps matching the beginnings of Tramp file names.
Keyed by Tramp syntax. Derived from `tramp-prefix-format-alist'.")

Best regards, Michael.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]