bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#28412: 26.0.50; Let save-some-buffers accept write-contents-function


From: Eric Abrahamsen
Subject: bug#28412: 26.0.50; Let save-some-buffers accept write-contents-functions
Date: Mon, 18 Sep 2017 11:14:35 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

>> From: Kaushal Modi <address@hidden>
>> Date: Mon, 18 Sep 2017 16:16:05 +0000
>> 
>> - I use ggtags.el that creates a hidden (is that the right term for that?) 
>> buffer (starting with space) to fontify
>> code snippets using the file's major mode.
>> - The major mode I use (verilog-mode) sets write-file-functions to a non-nil 
>> value.
>> 
>> So each time I quit emacs, I get a prompt to save that hidden buffer " 
>> *Code-Fontify*" (which it didn't earlier, as
>> intended).
>> 
>> Details: https://github.com/leoliu/ggtags/issues/157
>> 
>> I suggested calling (set-buffer-modified-p nil) in that special buffer. 
>> 
>> But is that the best way to fix this? Or should save-some-buffers never try 
>> to save buffers whose names begin
>> with space?
>
> Exempting buffers whose name starts with a space sounds reasonable.
> Eric?

Sounds fine to me. I'm trying to think if there's some more general
interactive-vs-non-interactive case that should be protected against,
but I can't really come up with anything. The whole point of
`save-some-buffers' is the user prompt, and this seems like a fine way
to create an exception to the prompt.

I can fix it up -- the patch should go to emacs-26, right?

Eric





reply via email to

[Prev in Thread] Current Thread [Next in Thread]