bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#28489: Acknowledgement (27.0.50; eieio-persistent slot type validati


From: Noam Postavsky
Subject: bug#28489: Acknowledgement (27.0.50; eieio-persistent slot type validation should be a bit smarter)
Date: Wed, 27 Sep 2017 22:23:14 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux)

Eric Abrahamsen <address@hidden> writes:

> It should be:
>
> (seq-filter #'eieio-persistent-slot-type-is-class-p (cdr type))

A right, that makes more sense.

> This whole section of code, `eieio-persistent-validate/fix-slot-value'
> and its neighbors, feels very seat-of-the-pants to me. I wish `cl-typep'
> could handle more of this work. But in the meantime this patch (or
> something like it) would at least address the actual bug.

Hmm, to be honest I can't quite make out what this function is actually
being used for.

> I don't think the tabs were my fault! What's Emacs policy on this?

I believe the policy is that new code should use spaces (although
sometimes people ignore this, it's not a big deal), but don't touch
lines just for the sake of changing the whitespace.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]