[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#28997: 27.0.50; Error in async shell-command process filter
From: |
Noam Postavsky |
Subject: |
bug#28997: 27.0.50; Error in async shell-command process filter |
Date: |
Tue, 31 Oct 2017 06:48:52 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) |
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> The first patch replaces the quoted lambda process filter
> with a closure over the name of output-buffer. By keeping
> track of this name, a lot of the surrounding
> buffer-name-determining code can be simplified via DRY.
This looks good to me.
> The second patch is purely aesthetic and simplifies the cond
> that is touched by my first patch into an equivalent pcase.
I'm not sure about this one. There was some contention in the past over
use of pcase, with some suggestions even to make an opposite
transformation, e.g., [1].
[1]: https://lists.gnu.org/archive/html/emacs-devel/2016-01/msg00055.html