[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unic

From: Paul Eggert
Subject: bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unicode file
Date: Thu, 2 Nov 2017 13:35:16 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

On 11/02/2017 08:50 AM, Eli Zaretskii wrote:
do you see a cleaner fix?

Yes, we can stop using alignas entirely, since it doesn't work the way I expected. I thought that it could only increase alignment, and that it was a no-op if it specified a decreased alignment: this is how __attribute__ ((aligned (8))) works. However, I now see that C11 says that a compiler is supposed to report an error if alignas specifies a decreased alignment. So I installed the attached patch to stop using alignas.

We've stopped supporting MSVC long ago.
OK. Can we then simplify the source a little bit, in the 'master' branch, as a low-priority task? I was thinking of something like this:

* Remove my_endbss_static in lastfile.c, since we no longer need to worry about the Alpha MSVC linker.

* Remove the the _MSC_VER-specific code in lisp.h's definitions of ENUM_BF and DEFUN and in regex.c's definition of re_char and const_re_char.

Attachment: 0001-Fix-alignment-portability-problems.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]