[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unic

From: Paul Eggert
Subject: bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unicode file
Date: Thu, 2 Nov 2017 22:03:17 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

Eli Zaretskii wrote:
Thanks, but I think the resulting code is confusing.  E.g.:

   static struct thread_state GCALIGNED main_thread;

This looks like we ask main_thread to be 8-byte aligned, which would
bring back the problems we had before.

I attempted to clarify this by installing the first attached patch into the emacs-26 branch. This patch adds a comment to the definition of GCALIGNED. If the name "GCALIGNED" itself is confusing, we can systematically change the name to something else. (The name doesn't confuse me, but perhaps I'm too close to the code.)

I don't know anything about that code, and I don't think anyone does.
Who will tell us that the comment is still accurate?

Since MSVC is no longer relevant, it doesn't matter whether the comment about MSVC is accurate, and we can remove it.

Anything that is conditioned by _MSC_VER can go.

I did that by installing the second attached patch into 'master'. This affects only the mainline code; I didn't fiddle with the MS-Windows-only files since I can't easily test them.

Attachment: 0001-src-lisp.h-GCALIGNED-Clarify-comment-Bug-29040.patch
Description: Text Data

Attachment: 0001-Simplify-by-assuming-_MSC_VER.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]