bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#18951: eshell-pcomplete removes asterisk when attempting completion


From: Dmitry Gutov
Subject: bug#18951: eshell-pcomplete removes asterisk when attempting completion
Date: Fri, 3 Nov 2017 23:25:34 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Thunderbird/56.0

On 11/2/17 4:15 PM, Daniel Kraus wrote:

Noam Postavsky <address@hidden> writes:

Hmm, does this do the right thing?

--- i/lisp/pcomplete.el
+++ w/lisp/pcomplete.el
@@ -772,7 +772,7 @@ pcomplete-parse-arguments
                (setq c (cdr c)))
              (setq pcomplete-stub (substring common-stub 0 len)
                    pcomplete-autolist t)
-             (when (and begin (not pcomplete-show-list))
+             (when (and begin (> len 0) (not pcomplete-show-list))
                (delete-region begin (point))
                (pcomplete-insert-entry "" pcomplete-stub))
              (throw 'pcomplete-completions completions))

I didn't test it too much if something else breaks but it
seems to work. pcomplete doesn't remove the * and company
mode also seems to work without problems now.

Looking good in my testing, and fixes the problem. Thanks!

pcomplete-completion-at-point is still buggy, of course, but no worse than before.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]