[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#29489: Obsolete gnus-remove-if and gnus-remove-if-not
From: |
Eric Abrahamsen |
Subject: |
bug#29489: Obsolete gnus-remove-if and gnus-remove-if-not |
Date: |
Tue, 28 Nov 2017 19:31:16 -0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Noam Postavsky <npostavs@users.sourceforge.net> writes:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> For the interim, all that matters is consistency:
>>
>> (let ((list nil)
>> (ob (make-vector 3 0)))
>> (intern "foo" ob)
>> (intern "bar" ob)
>> (intern "xxx" ob)
>> (gnus-remove-if-not (lambda (_) t) ob)) ;=> (xxx 0 0)
>
> But:
>
> (let ((list nil)
> (ob (make-vector 3 0)))
> (intern "foo" ob)
> (intern "bar" ob)
> (intern "xxx" ob)
> (gnus-remove-if-not (lambda (_) t)
> ob t)) ;=> (xxx bar foo)
Good catch! Thanks for that. I was too hasty, and had already moved on
to running the next patch.
There are only two places in the code where that third argument is
passed. I can rework those two locations so that they work properly,
until the next step is taken.