[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#29405: 27.0.50; message-faces: Doc fixes and syntax touch-ups
From: |
Katsumi Yamaoka |
Subject: |
bug#29405: 27.0.50; message-faces: Doc fixes and syntax touch-ups |
Date: |
Fri, 01 Dec 2017 18:56:54 +0900 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (i686-pc-cygwin) |
On Fri, 01 Dec 2017 10:51:06 +0200, Eli Zaretskii wrote:
>> From: "Basil L. Contovounesios" <contovob@tcd.ie>
>> Date: Wed, 22 Nov 2017 20:48:28 +0000
>> I attach three patches pertaining to the faces defined in
>> lisp/gnus/message.el in descending order of importance:
>> 1. Fix docstring mistakes and inconsistencies.
>> 2. Use define-obsolete-face-alias instead of duplicating it.
>> 3. Use the newer (DISPLAY . PLIST) face spec syntax,
>> as per `(elisp) Defining Faces'.
> Lars, Yamaoka-san -- any comments on these?
> I've installed the first one on the emacs-26 branch, as it's clearly a
> bugfix in doc strings. But I would like to hear your opinions on the
> rest.
I think all are very good fixes.
`3.' makes XEmacs malfunction AFAIK, but of course it's OK.
Thanks.