bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#29712: 26.0.90; Three emacs-26 elisp tests are failing on darwin


From: Eli Zaretskii
Subject: bug#29712: 26.0.90; Three emacs-26 elisp tests are failing on darwin
Date: Sat, 16 Dec 2017 18:47:00 +0200

> Date: Sat, 16 Dec 2017 16:42:18 +0000
> From: Alan Third <address@hidden>
> Cc: address@hidden
> 
> modified   lisp/term/ns-win.el
> @@ -354,7 +354,7 @@ ns-delete-working-text
>    ;; Used prior to Emacs 25.
>    (define-coding-system-alias 'utf-8-nfd 'utf-8-hfs)
>  
> -  (set-file-name-coding-system 'utf-8-hfs))
> +  (set-file-name-coding-system 'utf-8-hfs-unix))
>  
>  ;;;; Inter-app communications support.

Such a change is OK for master (assuming I understood you correctly,
and the current master doesn't have anything equivalent to the above).
On the release branch, I'd suggest to bind file-name-coding-system to
utf-8-hfs-unix, and tell in the commit log message not to merge to
master.

> I made the change and everything looks ok; the other tests still pass.
> I don’t know anything about coding systems, though, so I could be
> missing something.

I don't think you need to fear anything.  It's the right thing to do
on systems that allow CR in file names.

Thanks.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]