[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#30327: 27.0.50; Failures in files-tests.el on macOS
From: |
Michael Albinus |
Subject: |
bug#30327: 27.0.50; Failures in files-tests.el on macOS |
Date: |
Fri, 02 Feb 2018 23:03:15 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Alan Third <alan@idiocy.org> writes:
Hi Alan,
> Today I ran make check and two new failures popped up. It looks like
> they're from recent additions to files-tests.el.
>
> Log file attached.
>
> Test files-tests-file-name-non-special-file-truename condition:
> (ert-test-failed
> ((should
> (equal nospecial
> (file-truename nospecial)))
> :form
> (equal
> "/:/var/folders/rs/0j9q5wvj5qv1h4p08j_dnbvw0000gn/T/files-testskeK4ZJ"
> "/:/private/var/folders/rs/0j9q5wvj5qv1h4p08j_dnbvw0000gn/T/files-testskeK4ZJ")
My crystal ball tells me, that your temporary-file-directory is located
on a symlinked directory.
Does the following patch cures it?
diff --git a/test/lisp/files-tests.el b/test/lisp/files-tests.el
index 90e5ebf215..61e22a47af 100644
--- a/test/lisp/files-tests.el
+++ b/test/lisp/files-tests.el
@@ -353,7 +353,8 @@ files-tests--with-temp-file
(declare (indent 1) (debug ((symbolp symbolp &optional form) body)))
(cl-check-type name symbol)
(cl-check-type non-special-name symbol)
- `(let* ((,name (make-temp-file "files-tests" ,dir-flag))
+ `(let* ((temporary-file-directory (file-truename temporary-file-directory))
+ (,name (make-temp-file "files-tests" ,dir-flag))
(,non-special-name (file-name-quote ,name)))
(unwind-protect
(progn ,@body)
Best regards, Michael.
- bug#30327: 27.0.50; Failures in files-tests.el on macOS, Alan Third, 2018/02/02
- bug#30327: 27.0.50; Failures in files-tests.el on macOS, Noam Postavsky, 2018/02/02
- bug#30327: 27.0.50; Failures in files-tests.el on macOS,
Michael Albinus <=
- bug#30327: 27.0.50; Failures in files-tests.el on macOS, Alan Third, 2018/02/02
- bug#30327: 27.0.50; Failures in files-tests.el on macOS, Philipp Stephani, 2018/02/02
- bug#30327: 27.0.50; Failures in files-tests.el on macOS, Noam Postavsky, 2018/02/03
- bug#30327: 27.0.50; Failures in files-tests.el on macOS, Alan Third, 2018/02/03
- bug#30327: 27.0.50; Failures in files-tests.el on macOS, Noam Postavsky, 2018/02/03
- bug#30327: 27.0.50; Failures in files-tests.el on macOS, Alan Third, 2018/02/03
- bug#30327: 27.0.50; Failures in files-tests.el on macOS, Michael Albinus, 2018/02/03
- bug#30327: 27.0.50; Failures in files-tests.el on macOS, Noam Postavsky, 2018/02/03