[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#20489: [Emacs-diffs] master d48e07a: * lisp/simple.el (next-error-fi
bug#20489: [Emacs-diffs] master d48e07a: * lisp/simple.el (next-error-find-buffer-function): New defcustom.
Sat, 24 Feb 2018 23:34:35 +0200
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)
>> +(defun next-error-find-buffer-function-default (&optional avoid-current
> This looks like a syntax error to me (function without body). I know
> it's accepted (because various parts of the byte-compiler need special
> hacks to deal with it), but please always put a body (i.e. an explicit nil).
And without body there is no way to add a docstring.
>> +(defvar next-error-find-buffer-function
> should just say
> (defvar next-error-find-buffer-function #'ignore
Ah, before arriving to the function without body I mistakenly tried #'identity
(that didn't work) whereas I actually intended to try #'ignore.
But the question that I really don't understand is what to do with the function
next-error-buffer-on-selected-frame that now will have no reference in code,
no use by default. How the users are supposed to know that it's possible
to put add-function with this function in the init file? Should we document
this in the docstring of next-error-buffer-on-selected-frame or the docstring
of next-error-find-buffer-function together with examples of using add-function?