[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#30444: 26.0.90; browse-url-emacs sets default-directory to "https://
From: |
Michael Albinus |
Subject: |
bug#30444: 26.0.90; browse-url-emacs sets default-directory to "https://" |
Date: |
Wed, 14 Mar 2018 17:09:22 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Nicolas Petton <nicolas@petton.fr> writes:
Hi Nico,
> Here's a first tentative. It's probably naive though, as there might be
> some corner cases I didn't think of and I'm new to file-handlers.
I haven't tested thoroughly, but your tests look OK.
> + (should (equal (file-name-directory "https://foo.org")
> + "https://foo.org/"))))
This is OK, but I would add also
(should (equal (file-name-directory "https://foo.org/")
"https://foo.org/"))))
Maybe you could add also negative tests, for example for
(file-name-directory "not-a-uri://foo.org")
Best regards, Michael.
- bug#30444: 26.0.90; browse-url-emacs sets default-directory to "https://", Eli Zaretskii, 2018/03/10
- bug#30444: 26.0.90; browse-url-emacs sets default-directory to "https://", Michael Albinus, 2018/03/10
- bug#30444: 26.0.90; browse-url-emacs sets default-directory to "https://", Nicolas Petton, 2018/03/12
- bug#30444: 26.0.90; browse-url-emacs sets default-directory to "https://", Nicolas Petton, 2018/03/13
- bug#30444: 26.0.90; browse-url-emacs sets default-directory to "https://",
Michael Albinus <=
- bug#30444: 26.0.90; browse-url-emacs sets default-directory to "https://", Nicolas Petton, 2018/03/16
- bug#30444: 26.0.90; browse-url-emacs sets default-directory to "https://", Michael Albinus, 2018/03/18
- bug#30444: 26.0.90; browse-url-emacs sets default-directory to "https://", Nicolas Petton, 2018/03/18
- bug#30444: 26.0.90; browse-url-emacs sets default-directory to "https://", Nicolas Petton, 2018/03/18