[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#31139: [PATCH] Document Narrow indicator in describe-mode

From: Noam Postavsky
Subject: bug#31139: [PATCH] Document Narrow indicator in describe-mode
Date: Thu, 19 Apr 2018 08:16:50 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Michael Hendricks <address@hidden> writes:

> You're right that narrowing isn't exactly a minor mode.  However,
> standard-mode-line-format includes narrowing information as part of
> mode-line-modes.  So the narrowing indicator is rendered inside the
> same parentheses as indicators for true major and minor modes.  Since
> describe-mode provides documentation for everything else that's inside
> those parentheses, it seemed appropriate to document narrowing in the
> same place.

Okay, I'm convinced.  I think adding a comment along the lines of
"narrowing is not a minor mode, but its indicator is part of
mode-line-modes", would be helpful in case someone tries to "fix" your
change later.

> +     (when (or (> (point-min) 1) (<= (point-max) (buffer-size)))

You should use buffer-narrowed-p instead of checking point min & max

Have you assigned copyright for Emacs? (the patch is small enough to
install regardless, I'm asking just to know if it should be marked as a
tiny change).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]