bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25904: Formatting bug with js-mode


From: Dmitry Gutov
Subject: bug#25904: Formatting bug with js-mode
Date: Sat, 5 May 2018 00:37:13 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0

On 3/16/18 3:06 AM, Felipe Ochoa wrote:
This has taken a *little* longer than I'd hoped, but here's a new
patch with all the discussed changes. Hopefully I got the commit
message formatting and content right

Not really. First of all, I asked for an attached file ('git am' needs a file), and not its contents inside the message body. Which suffered word-wrap damage during transmission (because that's what email clients do).

I would commit it this time anyway, though, if not for the next point.

 From 0c7eed3fd9f7f77a071296c191e8569471bac4e5 Mon Sep 17 00:00:00 2001
From: Felipe Ochoa <address@hidden>
Date: Tue, 7 Nov 2017 16:50:42 -0500
Subject: [PATCH] Fixes js indentation after arrow function without parens

From: felipe <address@hidden>

* lisp/progmodes/js.el (js--proper-indentation)
(js--looking-at-broken-arrow-function-p)

I think there was going to be some description here.

And there's no mention of changes to js--continued-expression-p and js--proper-indentation. They would have the meat of the explanation.

* test/manual/indent/js.js: Indent expression following an arrow as
though it were enclosed in parentheses

This needs a period, at least.

(Bug#25904)

We usually put the bug number inside one of the sentences of the change log entry, not just at the end of it.

The patch does work, but if you could make the details right, it would be great. We've missed the emacs-26 train, so there's no real hurry.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]