bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#31466: 27.0.50; customize-apropos: Separate package name from its de


From: Tino Calancha
Subject: bug#31466: 27.0.50; customize-apropos: Separate package name from its description
Date: Thu, 07 Jun 2018 13:54:16 +0900
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Tino Calancha <address@hidden> writes:

> diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
> index a12897e799..1496e0b89f 100644
> --- a/lisp/cus-edit.el
> +++ b/lisp/cus-edit.el
> @@ -4145,7 +4145,9 @@ custom-group-value-create
>          ;; Update buttons.
>          (widget-put widget :buttons buttons)
>          ;; Insert documentation.
> -        (if (and (eq custom-buffer-style 'links) (> level 1))
> +        (if (and (eq custom-buffer-style 'links)
> +                 (or (> level 1)
> +                     (memq this-command '(customize-apropos 
> customize-apropos-groups))))
>              (widget-put widget :documentation-indent

I think we can just require
(eq custom-buffer-style 'links)
and go ahead indenting the documentation if such condition holds.

Then, we don't need `this-command', so that the doc will be indented
also in non-interactive calls.
--8<-----------------------------cut here---------------start------------->8---
commit dff8d8fb83f2e629e66380554c0b28e68db49868
Author: Tino Calancha <address@hidden>
Date:   Thu Jun 7 13:49:53 2018 +0900

    customize-apropos: Separate package name from its description
    
    * lisp/cus-edit.el (custom-group-value-create):
    Always insert documentation indented from its package name (Bug#31466).

diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
index a12897e799..ff6a4f6d33 100644
--- a/lisp/cus-edit.el
+++ b/lisp/cus-edit.el
@@ -4145,7 +4145,7 @@ custom-group-value-create
           ;; Update buttons.
           (widget-put widget :buttons buttons)
           ;; Insert documentation.
-          (if (and (eq custom-buffer-style 'links) (> level 1))
+          (when (eq custom-buffer-style 'links)
               (widget-put widget :documentation-indent
                           custom-group-doc-align-col))
           (widget-add-documentation-string-button

--8<-----------------------------cut here---------------end--------------->8---
In GNU Emacs 27.0.50 (build 23, x86_64-pc-linux-gnu, GTK+ Version 3.22.11)
 of 2018-06-05 built on calancha-pc
Repository revision: 4a51deb993d923767f0eddd4f350e636fe8d7c0b

If people OK with that, I'd like to push this fix.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]