[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#30872: incorrect byte-compile of closure called from local funcalled
bug#30872: incorrect byte-compile of closure called from local funcalled function
Mon, 11 Jun 2018 08:36:25 -0400
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
tags 30872 + patch
Stefan Monnier <address@hidden> writes:
> Looks sane, thank you. Even better would be to try and share this code
> rather than duplicate it. Please try and add some comment in the code,
> tho: it's rather dry (and yes, I know I'm largely to blame for it).
It seemed pretty okay to me; I was confused by the
(if (assq arg env) (push `(,arg) env))
for a bit, so I added a mention of the nil case to the cconv-convert
> Also don't forget to add a corresponding testcase.
Right, here it is. Should this go to emacs-26? It looks fairly safe to
me, but since I'm new to this code, I don't want to put too much weight
on my assessment.