bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#30964: python-mode failing "overlapping strings" assertion lately


From: Andreas Röhler
Subject: bug#30964: python-mode failing "overlapping strings" assertion lately
Date: Sun, 17 Jun 2018 09:33:09 +0200
User-agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 17.06.2018 00:36, Noam Postavsky wrote:
"Daniel Colascione" <address@hidden> writes:

So it turns out that it wasn't an off-by-one problem at all.  Instead,
python was using (re-search-forward (rx (syntax string-delimiter))), which
was matching incorrectly because re-search-forward didn't update syntax as
it matched. It didn't do that because regex matching in general wasn't
reentrant, and it wasn't reentrant because regex bytecode programs are
self-modifying.

I checked in some work that makes regex searching update syntax as needed.

It seems there were two separate problems.  The off-by-one error still
happens after your changes, so I pushed my patch to master.

[1: 05345babc9]: 2018-06-16 18:34:19 -0400
   Fix off by one error in python-mode assertion (Bug#30964)
   
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=05345babc988060cca540770599282102c34f2a7




Hi folks,

sorry, but as long as syntax-ppss has fundamentally issues, all fixing here will be vain. For the very same reason don't be surprised having not "found a reliable test case".

Cheers,
Andreas





reply via email to

[Prev in Thread] Current Thread [Next in Thread]