[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should res
bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate
Sun, 24 Jun 2018 16:46:02 -0400
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
João Távora <address@hidden> writes:
>> (defun save-buffers-kill-emacs (&optional arg)
>> ;; Don't use save-some-buffers-default-predicate, because we want
>> ;; to ask about all the buffers before killing Emacs.
>> (save-some-buffers arg t)
> Right, but thats because, when killing Emacs, it is really the last
> chance to save those buffers before they're potentially gone for good.
Oh, I got mixed up by the comment in server-save-buffers-kill-terminal:
;; If client is bufferless, emulate a normal Emacs exit
;; and offer to save all buffers. Otherwise, offer to
;; save only the buffers belonging to the client.
So I'd say your change is sensible, we should just update that comment
to explain the differences in the "emulation".