bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#31325: 27.0.50; PROPOSAL: introduce a new function to recenter witho


From: John Shahid
Subject: bug#31325: 27.0.50; PROPOSAL: introduce a new function to recenter without redisplaying the frame
Date: Sun, 01 Jul 2018 17:18:08 +0000
User-agent: mu4e 1.1.0; emacs 27.0.50

Eli Zaretskii <address@hidden> writes:

>> From: John Shahid <address@hidden>
>> Cc: address@hidden, address@hidden, address@hidden
>> Date: Sun, 01 Jul 2018 16:54:53 +0000
>>
>> It just occurred to me that this change will break backward
>> comparability for those who bind some key to the `recenter' command,
>> since now the second argument will always be nil and thus won't
>> redisplay.  Should we also change the interactive form of recenter to
>> use "p" for the second argument?  That way the second arg is never nil
>> when used interactively.
>
> I think you are right.
>
> Alternatively, we could simply make 'recenter' behave specially in
> interactive invocations.  But in any case, incompatible changes in
> behavior are bad, and should be avoided.

I am happy to make the change. Should we just revert this patch and
instead of adding a new argument change the behavior of`recenter' to
redraw if called interactively ?

How can we determine from C whether the function is called interactively
? Is it ok to use `called-interactively-p' ?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]