[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#32194: [PATCH] Use Gnulib regex for lib-src

From: Paul Eggert
Subject: bug#32194: [PATCH] Use Gnulib regex for lib-src
Date: Thu, 2 Aug 2018 07:41:38 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

Eli Zaretskii wrote:

I thought that using

   #include "regex.h"

in src/regex.c should avoid any such "fights".

The problem I ran into was the other way around: lib-src/etags.c and lib/regex.c say '#include <regex.h>' and this grabs the wrong regex.h. Changing the directives to say '#include "<regex.h>"' would start to diverge from glibc source, which I'd rather not do. Also, for non-POSIX compilers, the '#include "<regex.h>"' trick might not work; it also might not work if the builder puts '-I-' in CFLAGS with GCC. The whole mess is easily avoidable by renaming src/regex.h.

Renaming is appropriate anyway, since the APIs are not the same, and it's confusing to have two include files with the same name.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]