[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#32485: 27.0.50; Problem with zerop on 32-bit platforms

From: Paul Eggert
Subject: bug#32485: 27.0.50; Problem with zerop on 32-bit platforms
Date: Tue, 21 Aug 2018 13:54:11 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

vc-hg-state-fast might still need attention. Currently (zerop (lsh -1 32)) returns nil on all platforms, so it's useless; but that might change

This prompted me to audit the uses of lsh in the Emacs source code. I found and fixed a few glitches by installing the attached patch; in particular it fixes vg-hg-state-fast by using ash instead, as ash's semantics are clear and not subject to change. This patch goes further in this direction by replacing lsh with ash when either will do.

As this fixes the remaining problems mentioned in this bug report, I'm boldly closing the report.

Attachment: 0001-Audit-use-of-lsh-and-fix-glitches.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]